Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #215: Improve grunt build tasks and add grunt dist #225

Merged
merged 1 commit into from
Feb 5, 2016
Merged

Issue #215: Improve grunt build tasks and add grunt dist #225

merged 1 commit into from
Feb 5, 2016

Conversation

chill117
Copy link
Contributor

@chill117 chill117 commented Feb 1, 2016

No description provided.

@chill117 chill117 changed the title Issue #215: Improve grunt build tasks and add grunt build:dist Issue #215: Improve grunt build tasks and add grunt dist Feb 2, 2016
@kumilingus
Copy link
Contributor

Looks good.

  1. Please rebase.
  2. Could you update README.md?

@chill117
Copy link
Contributor Author

chill117 commented Feb 5, 2016

  1. Please rebase.

There are merge commits. Are you sure about that?

@kumilingus
Copy link
Contributor

There are merge commits. Are you sure about that?

Positive. There are merge commits with master. Rebase against master. git rebase upstream/master

@chill117
Copy link
Contributor Author

chill117 commented Feb 5, 2016

@kumilingus All set ;)

@kumilingus
Copy link
Contributor

Is grunt dist in README.md?

`grunt build:all` will no longer affect the dist directory.

Run `grunt dist` before running tests.
@chill117
Copy link
Contributor Author

chill117 commented Feb 5, 2016

Is grunt dist in README.md?

It is now :)

@kumilingus
Copy link
Contributor

Nice!

kumilingus added a commit that referenced this pull request Feb 5, 2016
Issue #215: Improve grunt build tasks and add `grunt dist`
@kumilingus kumilingus merged commit 9d2def3 into clientIO:master Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants